Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AspNetCore.Http 2.1.x track on netstandard2.0 #2417

Draft
wants to merge 2 commits into
base: v2.x
Choose a base branch
from

Conversation

davidmrdavid
Copy link
Contributor

@davidmrdavid davidmrdavid commented Mar 8, 2023

We've recently been informed by an automated dependency scan that AspNetCore.Http 2.2.x is affected by CVE-2020-1045
.
This CVE was resolved in AspNetCore.Http 2.1.x but not in AspNetCore.Http 2.2.x. This is apparently because the 2.2.x track went EOL before 2.1.x.

From my understanding thus far, this CVE may also be ignored when .NET Core app 3.1 or greater is used. This is still to be confirmed.

Given that our project uses multi-targeting, one target being netstandard2.0 and another being netcoreapp3.1, this PR only addresses the vulnerability in the netstandard2.0 target. This PR does this by downgrading our AspNetCore dependencies to the 2.1.x track, and pinning to the AspNetCore.Http version with the CVE fix.

Question: do we need to backport this change to DF V1?

Issue describing the changes in this PR

resolves N/A

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.

@davidmrdavid
Copy link
Contributor Author

davidmrdavid commented Mar 8, 2023

Putting this PR in draft mode as per fabio's recommendation. We're awaiting official AzFunctions Extension guidance before merging.

@davidmrdavid davidmrdavid marked this pull request as draft March 8, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant